Table - cell merging #4046
Merged
Table - cell merging #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
trueadm,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
thegreatercurve
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
This looks good to me but @tylerjbainbridge should probably have a look. @zurfyx Maybe add a couple of test cases for showing what happens when you insert/delete a column or row which contains or insersects one with a merged cell.
|
|
||
| type TableCellActionMenuProps = Readonly<{ | ||
| contextRef: {current: null | HTMLElement}; | ||
| onClose: () => void; | ||
| setIsMenuOpen: (isOpen: boolean) => void; | ||
| tableCellNode: TableCellNode; | ||
| cellMerge__EXPERIMENTAL: boolean; |
There was a problem hiding this comment.
We probably don't need to mark this as experimental if this is just in the playground. We'll just end up forgetting about it anyway
Suggested change
| cellMerge__EXPERIMENTAL: boolean; | |
| cellMerge boolean; |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for cell merging on the stable tables implementation. We store this with a simple
__colSpanand__rowSpanproperty on the GridCellNode.There are many follow ups from this PR, including the fact that only basic cases work for now:
getShape()- indexes fail when merged cells are presentCell merging
Screen.Recording.2023-03-07.at.4.49.26.PM.mov
(yes, the menu visibility needs a fix but we're considering dropping it for a better a11y alternative)
Selection is guaranteed to be rectangular
Screen.Recording.2023-03-07.at.2.58.29.PM.mov
More complicated selection
Screen.Recording.2023-03-07.at.3.13.29.PM.mov